https://bugzilla.redhat.com/show_bug.cgi?id=2108905 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #12 from Kalev Lember <klember@xxxxxxxxxx> --- Okay! Looks good to me then. Thanks for sorting out the builder issues with infra. Obsoletes and provides for the rename all look good, and otherwise the package is pretty much the same as the existing webkitgtk3 package. Here is the rpmlint output for completeness sake: $ rpmlint * =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 15 webkit2gtk4.1.x86_64: W: no-manual-page-for-binary WebKitWebDriver webkit2gtk5.0.x86_64: W: no-manual-page-for-binary WebKitWebDriver javascriptcoregtk4.0.x86_64: W: no-documentation javascriptcoregtk4.0-devel.x86_64: W: no-documentation javascriptcoregtk4.1.x86_64: W: no-documentation javascriptcoregtk4.1-devel.x86_64: W: no-documentation javascriptcoregtk5.0.x86_64: W: no-documentation javascriptcoregtk5.0-devel.x86_64: W: no-documentation webkit2gtk4.0.x86_64: W: no-documentation webkit2gtk4.0-devel.x86_64: W: no-documentation webkit2gtk4.1.x86_64: W: no-documentation webkit2gtk4.1-devel.x86_64: W: no-documentation webkit2gtk5.0.x86_64: W: no-documentation webkit2gtk5.0-devel.x86_64: W: no-documentation webkit2gtk4.0.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-4.0/injected-bundle/libwebkit2gtkinjectedbundle.so webkit2gtk4.1.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-4.1/injected-bundle/libwebkit2gtkinjectedbundle.so webkit2gtk5.0.x86_64: W: library-not-linked-against-libc /usr/lib64/webkit2gtk-5.0/injected-bundle/libwebkit2gtkinjectedbundle.so webkit2gtk4.0-doc.noarch: E: files-duplicated-waste 107957 webkit2gtk4.1-doc.noarch: E: files-duplicated-waste 107957 webkit2gtk5.0-doc.noarch: E: files-duplicated-waste 107957 webkit2gtk4.0.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk4.0/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk4.0/Source.WTF.wtf.dtoa.COPYING webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/fonts.css webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/fzy.js webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-4.0/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-4.0/go-up-symbolic.png webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/main.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/main.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/main.js webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/search.js /usr/share/gtk-doc/html/javascriptcoregtk-4.0/search.js:/usr/share/gtk-doc/html/webkit2gtk-4.0/search.js webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/solarized-dark.css webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/solarized-light.css webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/style.css /usr/share/gtk-doc/html/javascriptcoregtk-4.0/style.css:/usr/share/gtk-doc/html/webkit2gtk-4.0/style.css webkit2gtk4.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.0/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-4.0/urlmap.js webkit2gtk4.1.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk4.1/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk4.1/Source.WTF.wtf.dtoa.COPYING webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/fonts.css webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/fzy.js webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-4.1/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-4.1/go-up-symbolic.png webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/main.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/main.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/main.js webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/search.js /usr/share/gtk-doc/html/javascriptcoregtk-4.1/search.js:/usr/share/gtk-doc/html/webkit2gtk-4.1/search.js webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/solarized-dark.css webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/solarized-light.css webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/style.css /usr/share/gtk-doc/html/javascriptcoregtk-4.1/style.css:/usr/share/gtk-doc/html/webkit2gtk-4.1/style.css webkit2gtk4.1-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-4.1/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-4.1/urlmap.js webkit2gtk5.0.x86_64: W: files-duplicate /usr/share/licenses/webkit2gtk5.0/Source.WTF.wtf.dtoa.LICENSE /usr/share/licenses/webkit2gtk5.0/Source.WTF.wtf.dtoa.COPYING webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/fonts.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/fonts.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/fonts.css webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/fzy.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/fzy.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/fzy.js webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/go-up-symbolic.png /usr/share/gtk-doc/html/javascriptcoregtk-5.0/go-up-symbolic.png:/usr/share/gtk-doc/html/webkit2gtk-5.0/go-up-symbolic.png webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/main.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/main.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/main.js webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/search.js /usr/share/gtk-doc/html/javascriptcoregtk-5.0/search.js:/usr/share/gtk-doc/html/webkit2gtk-5.0/search.js webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/solarized-dark.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/solarized-dark.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/solarized-dark.css webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/solarized-light.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/solarized-light.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/solarized-light.css webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/style.css /usr/share/gtk-doc/html/javascriptcoregtk-5.0/style.css:/usr/share/gtk-doc/html/webkit2gtk-5.0/style.css webkit2gtk5.0-doc.noarch: W: files-duplicate /usr/share/gtk-doc/html/webkit2gtk-web-extension-5.0/urlmap.js /usr/share/gtk-doc/html/webkit2gtk-5.0/urlmap.js javascriptcoregtk4.0-devel.x86_64: E: description-line-too-long The javascriptcoregtk4.0-devel package contains libraries, build data, and header javascriptcoregtk4.0-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-4.0. javascriptcoregtk4.1-devel.x86_64: E: description-line-too-long The javascriptcoregtk4.1-devel package contains libraries, build data, and header javascriptcoregtk4.1-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-4.1. javascriptcoregtk5.0-devel.x86_64: E: description-line-too-long The javascriptcoregtk5.0-devel package contains libraries, build data, and header javascriptcoregtk5.0-devel.x86_64: E: description-line-too-long files for developing applications that use JavaScript engine from webkit2gtk-5.0. webkit2gtk4.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/1d/058cfee0aebc7c9bfd53d6e735382fe4763e29 ../../../../usr/libexec/webkit2gtk-4.0/MiniBrowser webkit2gtk4.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/74/d4a813fdc6f62850a9237e4cde25cfc4b334b0 ../../../../usr/libexec/webkit2gtk-4.0/jsc webkit2gtk4.1.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/63/1f5a3a69d3a27d8886308c90c56aa42e9fbe74 ../../../../usr/libexec/webkit2gtk-4.1/jsc webkit2gtk4.1.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/6b/9e89b3b81c63f6d5dc627ba62774721ddede18 ../../../../usr/libexec/webkit2gtk-4.1/MiniBrowser webkit2gtk5.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/14/9a285a9aa72e26215f9aa0e69dcf21e162a1d7 ../../../../usr/libexec/webkit2gtk-5.0/jsc webkit2gtk5.0.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/86/81f68b20aab7d65e5da6529864a25ae770f70b ../../../../usr/libexec/webkit2gtk-5.0/MiniBrowser ================================================== 15 packages and 0 specfiles checked; 9 errors, 53 warnings, 9 badness; has taken 15.7 s =================================================== APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2108905 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
