https://bugzilla.redhat.com/show_bug.cgi?id=2108905 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |klember@xxxxxxxxxx --- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> --- This seems broadly fine to me. Makes a lot of sense to build all of these from the same source package. I'd like to see a scratch build succeed before approving this though, just to make sure it has a chance of building in koji as the package is just so big. On the same note, maybe you could add the GTK4 version to the spec file already now, just to see if it's possible to build all 3 versions from the same package without running into issues with koji builders running out of memory? It's fine to just '%if 0' it out afterwards if you don't want to actually ship it yet. It's really up to you how prudent you want to be; we can always split this up afterwards again if koji can't handle building it. Another thing I noticed is that various 4.0 packages seem to be missing license files. Can you make sure they match with what's shipped in the 4.1 packages? e.g. %files -n webkit2gtk4.1-jsc %license _license_files/*JavaScriptCore* %{_libdir}/libjavascriptcoregtk-4.1.so.0* %dir %{_libdir}/girepository-1.0 %{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib %files -n webkit2gtk4.0-jsc %{_libdir}/libjavascriptcoregtk-4.0.so.18* %dir %{_libdir}/girepository-1.0 %{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib ... where the 4.0 version is missing %license. Upgrade path seems sane to me (all the various subpackages that got renamed from webkit2gtk3 -> webkit2gtk4.0 all seem to have correct obsoletes and provides). The sources are identical (and in fact, the binary package content as well, minus the license files issue pointed out above) is identical to what's shipped in rawhide right now so I think this package should be fine to go in. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2108905 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
