https://bugzilla.redhat.com/show_bug.cgi?id=2104123 --- Comment #7 from Sergio Lopez <slopezpa@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #6) > > cargo tree --workspace --offline --edges 'normal' --prefix none --format '{l}: {p}#' | cut -d\# -f1 | grep -v "($PWD" | sort -u > > You can remove this from the %build section again, as it's not needed for > "production" builds. > But you can save that command somewhere so you can reuse it when you need to > update the package next time. Yes, that's a leftover. > > BuildRequires: libkrun-devel > > I wonder why this is a normal BuildRequires, but you "echo" asciidoctor in > %generate_buildrequires? I think I copied that from some other package (rust-ripgrep maybe?). I've moved it now to be also a normal BuildRequires. > > Requires: buildah > > This is in the scope of the "rust-krunvm" package, which is only the source > package, but does not match any binary package. So this statement is a no-op. > I assume you want to move this to the "-n %{crate}" subpackage's scope, > which actually contains your krunvm binary (so alongside the license > breakdown). Ouch, I've fixed this one too. Thanks a lot for your comments. I've created a new COPR build: Spec URL: https://download.copr.fedorainfracloud.org/results/slp/rust-krunvm/fedora-rawhide-x86_64/04640663-rust-krunvm/rust-krunvm.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/slp/rust-krunvm/fedora-rawhide-x86_64/04640663-rust-krunvm/rust-krunvm-0.1.6-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104123 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
