[Bug 2104123] Review Request: rust-krunvm - Create microVMs from OCI images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2104123



--- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
> cargo tree --workspace --offline --edges 'normal' --prefix none --format '{l}: {p}#' | cut -d\# -f1 | grep -v "($PWD" | sort -u

You can remove this from the %build section again, as it's not needed for
"production" builds.
But you can save that command somewhere so you can reuse it when you need to
update the package next time.

> BuildRequires:  libkrun-devel

I wonder why this is a normal BuildRequires, but you "echo" asciidoctor in
%generate_buildrequires?

> Requires:       buildah

This is in the scope of the "rust-krunvm" package, which is only the source
package, but does not match any binary package. So this statement is a no-op.
I assume you want to move this to the "-n %{crate}" subpackage's scope, which
actually contains your krunvm binary (so alongside the license breakdown).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2104123
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux