https://bugzilla.redhat.com/show_bug.cgi?id=2107355 --- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for your responses. a) Would be helpful to have a Koji/Copr build > It's a noarch build, so the mock build that fedora-review does is "good enough". > A build in copr: > https://copr.fedorainfracloud.org/coprs/zbyszek/pyparsing-3/build/4634236/ Ok. Great. b) Ensure posted spec file matches that in the SRPM That's just fedora-review not understanding autochangelog. That diff is stuff added automatically by rpmautospec, and can be ignored. Ok. c) >> Is this program likely to be used through an egg interface? > I don't have the least idea. There's a .dist-info directory, I hope that enough. > There's one consumer of this — pyparsing — and it seems happy with the current packaging. Is it possible to use the %pyproject_wheel macro? See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dist_info_metadata d) There are tests upstream, https://github.com/tabatkins/railroad-diagrams/blob/gh-pages/test.py but the test used seems sufficient https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_tests -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2107355 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
