https://bugzilla.redhat.com/show_bug.cgi?id=2104533 --- Comment #8 from Dave Dykstra <dwd@xxxxxxxxxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04636006-fuse2fs/fuse2fs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dwd/fuse2fs/epel-7-x86_64/04636006-fuse2fs/fuse2fs-1.46.5-5.el7.src.rpm Description: FUSE file system client for ext2/ext3/ext4 file systems Fedora Account System Username: dwd Latest version is above. Below are my responses to the comments. (In reply to Maxwell G from comment #7) > - [!] You need to include a license breakdown comment over the License > field. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_multiple_licensing_scenarios. > > You can probably just copy > ``` > This package, the EXT2 filesystem utilities, are made available under > the GNU Public License version 2, with the exception of the lib/ext2fs > and lib/e2p libraries, which are made available under the GNU Library > General Public License Version 2, the lib/uuid library which is made > available under a BSD-style license and the lib/et and lib/ss > libraries which are made available under an MIT-style license. Please > see lib/uuid/COPYING for more details for the license for the files > comprising the libuuid library, and the source file headers of the > libet and libss libraries for more information. > ``` > from the NOTICE file Done > - [!]: NOTICE mentions other license files. Shouldn't those also be > installed? I don't see most of them in the source code. The RHEL8 e2fsprogs package https://git.centos.org/rpms/e2fsprogs/blob/c8s/f/SPECS/e2fsprogs.spec includes only the NOTICE file. In fact that spec file lists only GPLv2 on the main package, and fuse2fs is part of the main package. Maybe that would be sufficient for this package after all. What do you think? The other licenses are only on subpackages not installed. > - [!]: Please remove `Requires: fuse-libs`. This is handled by the > dependency generator. Done > - [!]: You need to escape the %make_build macro in the changelog by > adding an extra %. Done > NOTE: You probably should reset the Release to 1 when you import the > package to Fedora. It's fine to keep bumping it for the review if that > helps you keep track of the changes. Yes that is my plan, and I plan to have only one %changelog entry to start. > Rpmlint > ------- > fuse2fs.x86_64: W: position-independent-executable-suggested > /usr/sbin/fuse2fs > NOTE: This seems specific to EL 7. This error doesn't show up when > running rpmlint against the version that's built for rawhide. Not sure > if EL 7's compiler flags have -fPIE Sounds like it is optional, so let's leave it out. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2104533 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
