Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: amanith - Crossplatform framework for 2d/3d vector graphics https://bugzilla.redhat.com/show_bug.cgi?id=399941 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-12 10:06 EST ------- For 0.3-2 * Dependency for -devel package - Please check the dependency (Requires) for -devel subpackage. For example, %_includedir/%name/gopenglext.h contains: ------------------------------------------------------------ 32 #include <GL/glew.h> 33 // this inclusion to make glew linking working with some platforms (ex: Mac) 34 #include "amanith/gelement.h" 35 #ifdef G_OS_WIN 36 #include <GL/wglew.h> 37 #endif ------------------------------------------------------------ This means amanith-devel should have "Requires: glew-devel". * SourceURL - I recommend to use %{version} tag so that you probably don't have to change SourceURL when the new version is released. ! Some misc ------------------------------------------------------------- export AMANITHDIR=${RPM_BUILD_DIR}/%{name} ------------------------------------------------------------- - I like: export AMANITHDIR=$(pwd) (not a blocker) * Documents - Usually the file "INSTALL" is needed for people who want to build and install the package by themselves and is not needed for people who install the package using rpm. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review