[Bug 2106171] Review Request: python-rfc3986-validator - A pure python RFC3986 validator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2106171



--- Comment #6 from Maxwell G <gotmax@e.email> ---
Thanks for incorporating my changes.

> - I prefer to keep that convention with slugname even if used once if you don't mind

I don't agree with it, but as I said, it's up to you :).

> - added a patch removing the pytest-runner from the setup.py (I'll try to escalate the issue upstream)

Thanks. Please leave a comment explaining the patch and a comment linking to
the upstream issue or at least saying that it will be submitted upstream. You
can also shorten Patch0 to Patch, if you'd like.

> %bcond_with tests

Please enable the tests.

> PYTHONWARNINGS=ignore %python3 -m pytest tests

Please use the %pytest macro.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106171
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux