https://bugzilla.redhat.com/show_bug.cgi?id=2104533 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email Doc Type|--- |If docs needed, set a value --- Comment #1 from Maxwell G <gotmax@e.email> --- Some initial comments: > Group: System Environment/Base Group tags must not be present in Fedora specfiles. > ./configure Does this project use autotools? If so, you should use %configure. Also, please use `%make_build` instead of calling make directly, if possible. > cp misc/%{name} %{buildroot}%{_sbindir}/ > cp misc/%{name}.1 %{buildroot}%{_mandir}/man1 This should be `cp -p` You're missing the URL directive. > # download with: > # $ curl -o %{name}-%{version}.tar.gz \ > # https://codeload.github.com/tytso/e2fsprogs/tar.gz/v%{version} > Source0: %{name}-%{version}.tar.gz Don't do this, if you can avoid it. Use https://github.com/tytso/e2fsprogs/archive/v%{version}/%{name}-%{version}.tar.gz instead. > %{!?_licensedir:%global license %%doc} Shouldn't this be above the first usage of %license? Also, please install the README in %doc. > License: GPLv2 The project is not entirely licensed under the GPLv2 and other licenses apply. Please make sure to include all of these in the License tag. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2104533 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
