https://bugzilla.redhat.com/show_bug.cgi?id=2103380 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > But if it bilds with -a, does that mean it can stay bumped? Anyway unbumped it. I think it can. According to the release notes, the most invasive change for nix 0.24 was that features can now be enabled separately. But by default, everything is still enabled. So since this crates uses default features, it should not be affected by this change. https://github.com/nix-rust/nix/blob/master/CHANGELOG.md#0240---2022-04-21 === I now see that you're also manually removing test binaries and the binary subpackage from the .spec file. You'll also need to define __cargo_is_bin false to fully disable the "build a binary" mode, like here: https://src.fedoraproject.org/rpms/rust-assert_cmd/blob/rawhide/f/rust-assert_cmd.spec#_5 That way, the binaries won't be installed, and you won't need to remove them manually (drop the lines below entirely): > # We don't actually need this > rm -rfv %{buildroot}%{_bindir}/context_integration_tests \ > %{buildroot}%{_bindir}/test_executables_helper \ > %{buildroot}%{_bindir}/test_executables_panic === Please also make sure to remove all unwanted files from the shipped package. Either by adding the following to the Cargo.toml: exclude = ["/justfile"] Or by adding this line to "%files devel" in the .spec file: %exclude %{cargo_instdir}/justfile Not sure if the README.php file can cause issues, but at least it doesn't generate an automatic dependency on /usr/bin/php ... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2103380 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
