https://bugzilla.redhat.com/show_bug.cgi?id=2103380 --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Small problems: > > 1) Your Cargo.toml patch: > > [target."cfg(unix)".dependencies.nix] > -version = "0.22.2" > +version = "0.24.1" > optional = true > > This is most probably not safe and broken, and you just don't see it because > that code is optional not compiled by default. > There have been quite extensive API changes between nix versions 0.23 and > 0.24. > Just drop this from the patch, we also have rust-nix0.22 packaged as a > compat package for nix 0.22.x. > But if it bilds with -a, does that mean it can stay bumped? Anyway unbumped it. > [target."cfg(unix)".dependencies.gag] > -version = "0.1.10" > +version = "1" > optional = true > > Same applies here. Does the code actually compile against the new version > (i.e. if you call all the %cargo_* macros with "-a")? The only changes between 0.1.10 and 1 were Windows fixes. No api changes. > > 2) Problems with how the %cargo_* macros are used: > > echo 'vim-common' > echo 'crate(gag)' > echo 'crate(nix)' > echo 'crate(memoffset)' > > This should never be needed. If the tests require some optional dependencies > to be present, use the "-a" ("--all-features") flag for > %cargo_generate_buildrequires, %cargo_build, %cargo_install, and %cargo_test. > Ok, done. > 3) Workaround for test failures: > > > https://github.com/soenkehahn/cradle/blob/main/memory-tests/Cargo.toml > > This indicates that the "memory-tests" sub-crate is not published, and it's > obviously also not included in published sources for cradle. > Just skip the test that tries to access it (i.e. use "%cargo_test -- -- > --skip memory_test") or patch it out of tests/integration.rs (it's at the > bottom of the file). > > > "won't work in rust test cases" > > Just add a link to the upstream README and use --nocapture, as indicated > there. > > In total, you should probably call %cargo_test like this: > > # * work around IO redirection in test harnesses with --nocapture > # * skip a test that tries to read files that are not present in published > crates > %cargo_test -a -- -- --nocapture --skip memory_test > > With that, you should not need to ignore %cargo_test with || :. > It works, thanks! > === > > If you have time, it would be great to get > https://bugzilla.redhat.com/show_bug.cgi?id=2090196 reviewed, in turn. > This ticket is currently blocking pending updates for the openssl / > openssl-sys crates. Will do -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2103380 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
