https://bugzilla.redhat.com/show_bug.cgi?id=2095005 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > Re the removed pytest constraint, is that because of the versioned dependencies guideline in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies ? I’m aware of that guideline, and typically follow it in the general case, but for manual dependencies in Python packages I tend to preserve dependency versions because this is what generated BR’s would do, and I’d rather follow that precedent than the general “SHOULD” guideline. I acknowledge that the best approach in this case is debatable. Instead, I removed the version constraint because it comes from the upstream test_requires keyword argument to setuptools.setup(), which is removed by the PR that I offered upstream, and I wanted the spec file to reflect the patched sources. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2095005 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
