https://bugzilla.redhat.com/show_bug.cgi?id=2095005 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #5 from Maxwell G <gotmax@e.email> --- Thanks for fixing the pytest-runner thing and submitting it upstream! > I am grateful for the information on support for %{python3_pkgversion}, in case that is ever something other than “3” on an EPEL newer than EPEL7. That’s good to know. RHEL 8 has python38 and python39. Side note: I already maintain ansible for python38 in EPEL 8, because ansible-core is packaged for that version in RHEL 8 due to upstream requirements. I am working on getting a stripped down version of pyproject-rpm-macros for python38 and python39 which have new enough versions of pip to be compatible. It's stripped down, because %tox (I haven't packaged it yet, but I may) and %pyproject_buildrequires (RHEL 8's rpm is too old) are removed. I am working on it in this[1] COPR. In terms of alternative buildsystems, I've packaged flit and I'm working towards poetry-core. I'm not sure if this is something you're interested in, but I figured I'd let you know. [1]: https://copr.fedorainfracloud.org/coprs/gotmax23/python38-epel8_2/ > You know, I picked up that habit a long time ago after I saw it somewhere, and I could have sworn I tried it. But you’re right, so I’ve fixed it, and I’ll make a project of fixing it in other packages that use the same pattern. At least the extra newline is only a trivial annoyance rather than a serious defect. Yeah, you're right. It's a pretty minor issue, but thank you for fixing it! >> It looks like the unit tests are being installed to `%{python3_sitelib}`. Is that something we want? > > This doesn’t seem to be the case. Check files.dir in the fedora-review output, or: You're right. I have no idea why I thought that was the case, as I looked at files.dir. I was working with another package that does this yesterday, so maybe my brain was seeing things... In any case, you're package is approved. I didn't see the need to re-run Fedora review, but I did successfully rebuild your package and inspected the specfile diff. Re the removed pytest constraint, is that because of the versioned dependencies guideline in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependencies ? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2095005 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
