https://bugzilla.redhat.com/show_bug.cgi?id=2087264 --- Comment #5 from Gustavo Costa <xfgusta@xxxxxxxxx> --- > 1) Not necessary for further packaging, but maybe helpful to update what is available at: > https://copr.fedorainfracloud.org/coprs/xfgusta/bfs/ The "BuildRequires: acl" is mostly a cosmetic change. I will update it when upstream releases a new version. > 2) Not clear to me how to evaluate "Package does not own files or directories owned by other packages.", it seems ok, but an explanation on the co-owned directories is helpful. Since bfs doesn't require bash or zsh -completion to work properly, there's no need to install them along with the package. But the package should own the directories they provide (/usr/share/bash-completion/completions and /usr/share/zsh/site-functions). Several packages do this and co-own these directories as well. See [1] and [2] > 3) Thanks for adding this to the Fedora ecosystem :) 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership 2. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2087264 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure