https://bugzilla.redhat.com/show_bug.cgi?id=2094422 --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Benson Muite from comment #4) > In the spec file: > Source0: %{forgeurl}/archive/v%{version}/libaiff-%{version}.tar.gz > should be > Source0: %{forgeurl}/archive/refs/tags/v%{version}.tar.gz Thank you for the suggestion. The URL I have is correct/usable, and I think it is preferable because it produces a better tarball name. - This form of GitHub URL has worked for many years, even if it’s not well-documented. - The resulting tarball is easier to identify by name. - The tarball name matches the name of the directory it contains, which is a long-standing convention in source archive releases. - This form of GitHub URL is widely used in other Fedora packages and matches the %{forgesource} that would be generated by the “forge” macros[1]—which I have not used here because they would not simplify things enough to compensate for the added macro indirection. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_release_example -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2094422 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
