https://bugzilla.redhat.com/show_bug.cgi?id=2091372 Onuralp Sezer <thunderbirdtr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Onuralp Sezer <thunderbirdtr@xxxxxxxxx> --- Also in case of repository changes (we discuss this in kde meeting) please add back BR cmake and install vith "cmake" way macro but keep noarch. So in future when cmake changes or files updated. We don't have to do change spec file too. That means you should add back build section as well. Rest is LGTM. I'm approving package but please do changes as well. Thank you. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2091372 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
