https://bugzilla.redhat.com/show_bug.cgi?id=2091372 --- Comment #4 from marcdeop@xxxxxxxxxxxxxxxxx --- (In reply to Onuralp Sezer from comment #3) > First please change license section into this one > (https://fedoraproject.org/wiki/Licensing:Main) > > License: LGPLv3+,CC0,BSD > Added > Second you're not installing via "cmake" file and since you're were only > copying "sound" files as installation, which means we can remove these BR(s) > > BuildRequires: extra-cmake-modules > BuildRequires: cmake > BuildRequires: qt5-qtbase-devel > Removed. I should have catched this initially. Apologies > > Also %build section is empty which means we don't need no debug variable > as well > > # debuginfo.list ends up empty/blank anyway. disable > %global debug_package %{nil} > This was only there because rpmlint was giving me a warning for not having a %build section and the moment I added it then I was getting an error only solvable by adding this. Regardless, I've removed the %build section altogether (even with the W from rpmlint) > And we make it "noarch" since this is just a "sound package" It is not > depend on any arch as well. > > BuildArch: noarch > Done > > You're also missing license section in files so we need that to as well. > > %files > %license LICENSES/*.txt Done -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2091372 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
