[Bug 2091296] Review Request: fastnetmon - Volumetric DDoS detection tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2091296



--- Comment #2 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
> fastnetmon_fedora.spec

SPEC must have the same name as the package name, i.e. fastnetmon.spec.

> * Saturday May 27 2022 Pavel Odintsov <pavel.odintsov@xxxxxxxxx> - 1.2.2-1

error: bad date in %changelog: Saturday May 27 2022 Pavel Odintsov
<pavel.odintsov@xxxxxxxxx> - 1.2.2-1

Please fix this. The correct changelog line should look like this:

* Fri May 27 2022 Pavel Odintsov <pavel.odintsov@xxxxxxxxx> - 1.2.2-1

> Source0:           https://github.com/pavel-odintsov/fastnetmon/archive/master.tar.gz

Please use tagged version or switch to the snapshots packaging, as described
here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

> %sysusers_create_compat src/fastnetmon.sysusers

fastnetmon.sysusers must be a part of the SRPM package.

Add it as Source1: fastnetmon.sysusers, because it will be expanded during the
build process to a scriptlet.

> %global  fastnetmon_user           root
> %global  fastnetmon_group          %{fastnetmon_user}
> %attr(700,%{fastnetmon_user},%{fastnetmon_group}) %dir %{fastnetmon_attackdir}

Root user here, but fastnetmon in fastnetmon.sysusers. Should be fixed.

> %global  fastnetmon_project_name fastnetmon
> %global  fastnetmon_company      FastNetMon LTD

Not used. Can be removed.

> Provides:          fastnetmon

Should be removed, because it has the same name as the main project. Will be
exported automatically.

> %global _vpath_srcdir src

Can be replaced with `-S src` parameter of the %cmake macro.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2091296
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux