[Bug 2091291] Review Request: nebula - A scalable overlay networking tool with a focus on performance, simplicity and security

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2091291

Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikel@xxxxxxxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |mikel@xxxxxxxxxxxxxxx



--- Comment #1 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
- You're installing a systemd service but spec is missing systemd scriplets.
Check
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd

- RPM build warnings:
    File listed twice: /usr/share/doc/nebula/README.md
    File listed twice:
/usr/share/doc/golang-github-slackhq-nebula-devel/README.md

I think that removing `cert/README.md` from %doc would do the trick

- The service file will check for /etc/nebula/config.yml config file, but it's
missing. You can use the example file nebula-1.5.2/examples/config.yml for
example. 

You can check jdoss' spec file, lines 88 and 114:
https://copr-dist-git.fedorainfracloud.org/cgit/jdoss/nebula/nebula.git/tree/nebula.spec 

- Maybe you want to add a `Fedora` string to the Build version, something like
%{version}-Fedora. Check line jdoss' line 77 or doctl's spec to see how to
export LDFLAGS.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2091291
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux