[Bug 2086484] Review Request: neomutt - Email Client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2086484



--- Comment #8 from Carl George 🤠 <carl@xxxxxxxxxx> ---
I took a look at the spec file attachment, and things are looking real good,
but two small new issues were introduced.

I imagine you added `rpm --showrc` for troubleshooting, but it should not be
included in the final spec file.  Pro-tip, this command also works in a
container.  Make sure to install redhat-rpm-config (and epel-rpm-macros for EL
releases) for all macros to be available.

Your multi-line configure is missing an escape after --full-doc, so the
conditional flags after that won't be included.

One more thing, please post revisions to the package as new `Spec URL:` and
`SRPM URL:` lines (with working URLs), similar to the original comment
template.  You don't have to repeat the `Description:` or `Fedora Account
System Username:` lines.  The fedora-review tool doesn't work with attachments,
it expects URLs in that format and will pick the last occurrences of those
lines in the comments of the given bug.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2086484
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux