https://bugzilla.redhat.com/show_bug.cgi?id=2086484 --- Comment #7 from Carl George 🤠 <carl@xxxxxxxxxx> --- > It's all gone OK, except for RHEL7 -- it's just too old. > If we don't even try to support RHEL7, then the spec file is trivial. It's up to you. You can build for as many or as few EPEL branches as you want. If you prefer to keep the spec file cleaner, it's ok to avoid EPEL7. You can always add it later if you change your mind. > I've done my best to comment the exceptions from GPLv2+. > Suggestions welcome. Looks great! > Done. This _mostly_ works. > RHEL7 seems to require me to add `CC=gcc` to %configure > (other systems seem to work ok without it) I imagine it's a problem with the much older version of gcc, or perhaps just the older rpm macros. Probably not worth the hassle of pinning it down when we can just skip building for EPEL7. > I did this, but then it complained that LICENSE.md was installed but not > packaged. Currently the spec has both %license and %doc for LICENSE.md That is strange. The one line should be sufficient to copy the file to the correct location and own the file. Do you have a local ~/.rpmmacros file that is overriding %license? Does it happen when building for Fedora and EPEL, or just EPEL? > I gave this a try, but I couldn't figure it out. That's ok, it's not strictly required. We don't need to block the review on it. In the future if anyone strongly wants it they can send a pull request to implement it. > Is there some simple way to set the install dir to just 'neomutt'? Yes, you can do `%global _docdir_fmt %{name}`. Be aware this may cause issues if multiple subpackages share ownership of any of the doc files (see bug 1625015). I would put AUTHORS.md, ChangeLog.md, README.md, and SECURITY.md only in the main package, and everything else only in neomutt-doc. Also, the INSTALL.md file should be omitted entirely, as it won't be relevant for people that install the rpm. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2086484 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
