https://bugzilla.redhat.com/show_bug.cgi?id=2069418 --- Comment #9 from Peter Robinson <pbrobinson@xxxxxxxxx> --- > What you need to do is provide a short explanatory comment *why* you have > *already manually edited* the .spec file that was generated by rust2rpm (to > disable dev-dependencies and not run the test suite). Yes, I normally do, clearly something slipped through the cracks, it wasn't malicious or intentional, it was probably an oversight from testing when tired/stressed, I feel I have enough credit with in the community to be given the benefit of the doubt here. I don't see why a simple "this needs a comment as to why you're disabling tests, please ensure you do this on commit" wouldn't have been enough. Spec/srpm now updated. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2069418 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
