[Bug 2069418] Review Request: rust-ciborium - Serde implementation of CBOR using ciborium-basic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2069418



--- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
It looks like there's mutual misunderstanding ...

What you need to do is provide a short explanatory comment *why* you have
*already manually edited* the .spec file that was generated by rust2rpm (to
disable dev-dependencies and not run the test suite).

You replaced the line

%bcond_without check

with just

%bcond_with check

but it should have been replaced with *two lines* like these

# * missing dev-dependency: rstest
%bcond_with check

because the reason for disabling a package's test suite needs to be documented
in the .spec file.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2069418
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux