https://bugzilla.redhat.com/show_bug.cgi?id=2086523 --- Comment #6 from Sergio Lopez <slopezpa@xxxxxxxxxx> --- (In reply to Lokesh Mandvekar from comment #5) > Pasting only the pending manual review part below.. > > Sergio, please fix the one TODO and we should be good to go. > > ===== MUST items ===== > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "*No copyright* Apache License 2.0", > "BSD 3-Clause License", "Apache License 2.0". 29 files have unknown > license. Detailed output of licensecheck in /home/lsm5/fedora- > review/virtiofsd/2086523-virtiofsd/licensecheck.txt > [x]: License file installed when any subpackage combination is installed. > [x]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/qemu/vhost-user > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/qemu/vhost-user, > /usr/share/qemu > > TODO: Need to own dirs %{_datadir}/qemu and %{_datadir}/qemu/vhost-user Good catch. I was planning to include "qemu-common" as a dependency, but I've just checked its spec and it doesn't declare the ownership either. I've created a BZ (https://bugzilla.redhat.com/show_bug.cgi?id=2086836) to the "qemu-common" package and updated the specfile of virtiofsd to depend on it. New COPR build: - https://download.copr.fedorainfracloud.org/results/slp/virtiofsd/fedora-rawhide-x86_64/04416518-virtiofsd/virtiofsd.spec - https://download.copr.fedorainfracloud.org/results/slp/virtiofsd/fedora-rawhide-x86_64/04416518-virtiofsd/virtiofsd-1.2.0-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2086523 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
