[Bug 2086299] Review Request: ansible-collection-community-libvirt - Manages virtual machines supported by libvirt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2086299



--- Comment #10 from Maxwell G <gotmax@e.email> ---
(In reply to Paul Howarth from comment #9)
> (In reply to Maxwell G from comment #7)
> > (In reply to Paul Howarth from comment #4)
> > > Hi Maxwell, thanks for the suggestions.
> > > Any idea why that should happen?
> > 
> > I'm not sure why this would happen. There might be some package update
> > that's related to this in the koji buildroot but not your mock chroot. You
> > can pass `--enablerepo=local` to mock to pull in the koji buildroot packages
> > and see if that fixes the problem.
> 
> It didn't help :-(

I'm not sure then. We can manually disable/exclude the package note file for
now. I believe this @zbyszek's area of expertise, so maybe you can ask him.


> > (In reply to Paul Howarth from comment #5)
> > > Another thing: %{ansible_collection_url} isn't expanded in EPEL-9 (at least
> > > with local builds):
> > 
> > Do you have `ansible-packaging` installed? I don't think it's part of the
> > default buildroot. I would revert the change you made to replace
> > %{ansible_collection_url}.
> 
> I do have ansible-packaging installed but I don't think that's related
> because I can rebuild (in mock) the same SRPM for Fedora and EPEL-9 (using a
> CentOS Stream buildroot) and the latter doesn't get
> %{ansible_collection_url} expanded in the resulting rebuilt SRPM but the
> former does. Hence I'd rather keep the URL as it is until we can figure out
> how to fix that.

That's fine with me. I will try to look into it.


> (In reply to Maxwell G from comment #8)
> > > %pyproject_buildrequires -N  %{python3_sitelib}/ansible_test/_data/requirements/units.txt\
> > 
> > It looks there's an extra space after the `-N`. This might have been my
> > fault. It's purely cosmetic, but I noticed it and figured I'd point it out.
> 
> I'll fix that next time I update the spec.

+1


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux