[Bug 2086267] Review Request: budgie-screensaver - A fork of gnome-screensaver intended for use with Budgie Desktop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2086267



--- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> Issues:
> =======
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
>   file-validate if there is such a file.

This is fixable by adding BuildRequires: desktop-file-utils and adding a %check
section to use desktop-file-validate on the desktop file.

See:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage

> [!]: Spec file according to URL is the same as in SRPM.
>      Note: Spec file as given by url is not the same as in SRPM (see
>      attached diff).
>      See: (this test has no URL)

The diff is trivial and will be reconciled on import, I expect (changelog date
differences).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux