https://bugzilla.redhat.com/show_bug.cgi?id=2080472 --- Comment #4 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > I deliberately don't do that with packages I maintain. I maintain hundreds > of packages, and have developed some workflows to deal with that many > packages. I grep spec files fairly frequently for various reasons. The > BR-generating functionality hides the BRs from me. I have to take extra > steps, one package at a time, to recover them. I have chosen to not do that. I wanted to make sure you were aware of generated BR’s since they make *most* people’s workflows a lot easier. They are not mandatory, and your preference is valid. > > Note that, since this runs after %prep, the generated BR’s include jinja2, > > which you > > added in %prep. > > Not exactly. The problem isn't a BR on jinja2, it is a missing runtime > dependency (R) on jinja2. I need to talk to upstream about that. I was trying to point out—not clearly enough, I suppose—that the jinja2 runtime dependency added in %prep does in fact result in a generated BR on jinja2 just as happens for the other, pre-existing runtime dependencies. This detail doesn’t matter since you won’t be using generated BR’s. > > > %doc README.md > > I don't know what you mean. That line is already in the spec file. That was just a brain glitch on my part, apparently. ----- Since you’ve considered the suggestion to generate BR’s and chosen not to, I think everything is fine here. I see that I had already approved the package since there were no *required* changes, so please carry on! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2080472 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
