https://bugzilla.redhat.com/show_bug.cgi?id=2080472 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Ben. (In reply to Ben Beasley from comment #1) > First, please consider generating BuildRequires as suggested in the Issues > section below. The ability to do this is a huge benefit of the > pyproject-rpm-macros, and it’s how they are normally intended to be used. I deliberately don't do that with packages I maintain. I maintain hundreds of packages, and have developed some workflows to deal with that many packages. I grep spec files fairly frequently for various reasons. The BR-generating functionality hides the BRs from me. I have to take extra steps, one package at a time, to recover them. I have chosen to not do that. > Second, since you are probably packaging this to generate HTML documentation > with it, please note that even though we have historically packaged > Sphinx-generated HTML documentation, it’s been pointed out that the > generated documentation includes bundled and pre-minified JavaScript and CSS > that seems to be incompatible with the packaging guidelines as currently > written. See bug 2006555 and > https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproject. > org/thread/LLUAURXZVADATHK65HBPPBHKF4EM4UC3/ for discussion on the topic. > Building PDF documentation instead is probably an acceptable workaround; I > can provide examples, PRs, and debugging assistance if you ever want to go > in that direction for a particular package. Okay, I can look into generating PDF documentation. > Note that, since this runs after %prep, the generated BR’s include jinja2, > which you > added in %prep. Not exactly. The problem isn't a BR on jinja2, it is a missing runtime dependency (R) on jinja2. I need to talk to upstream about that. (In reply to Ben Beasley from comment #2) > Oh, one more thing: it would be nice to package the README file by adding > > > %doc README.md I don't know what you mean. That line is already in the spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2080472 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
