[Bug 2076374] Review Request: trafficserver - Fast, scalable and extensible HTTP/1.1 and HTTP/2 caching proxy server

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2076374



--- Comment #22 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Issues:
=======
> - No %config files under /usr.
>   Note: %config(noreplace)
>   /usr/lib/systemd/system/trafficserver.service%config(noreplace)
>   /usr/lib/sysusers.d/trafficserver.conf%config(noreplace)
>   /usr/lib/tmpfiles.d/trafficserver.conf
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_configuration_files

Yeah, these are not config files, drop %config stanzas here. User configuration
and overrides for files in /usr/lib will be written in /etc as needed by the
user and systemd will do the right thing automatically.

> - Package does not use a name that already exists.
>   Note: A package with this name already exists. Please check
>   https://src.fedoraproject.org/rpms/trafficserver
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/Naming/#_conflicting_package_names

This can be ignored, since you're unretiring a package.

> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /var/lib/selinux/targeted/active/modules/200,
>      /usr/share/selinux/packages/targeted, /usr/share/perl5/Apache/TS,
>      /usr/share/perl5/Apache/TS/Config,
>      /usr/share/selinux/devel/include/distributed, /usr/share/perl5/Apache,
>      /usr/include/tscpp
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/include/tscpp,
>      /usr/share/perl5/Apache/TS/Config,
>      /usr/share/selinux/devel/include/distributed,
>      /usr/share/selinux/devel,
>      /var/lib/selinux/targeted/active/modules/200, /usr/share/perl5/Apache,
>      /usr/share/selinux/devel/include,
>      /usr/share/selinux/packages/targeted, /usr/share/perl5/Apache/TS

The SELinux and Perl module subpackages need correct ownership of their
directories.

> [!]: Uses parallel make %{?_smp_mflags} macro.

This is it misdetecting the SELinux module make call, it can be ignored.

> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>      trafficserver-selinux , trafficserver-devel , trafficserver-perl

The selinux subpackage is fine as-is, but the rest need their "%{name} =
%{version}-%{release}" dependency updated to "%{name}%{?_isa} =
%{version}-%{release}".


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076374
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux