https://bugzilla.redhat.com/show_bug.cgi?id=2074401 --- Comment #2 from Julien Rische <jrische@xxxxxxxxxx> --- I fixed the error in the date and removed the font files from the git repository in the %prep section. I also used desktop-file-install to install the .desktop file. I doubt the Engine code is meant to be compiled as a standalone library. When I try to do so, I get: ERROR: First statement must be a call to project There are no version tags in the Engine repository, so I just used the commit hash reference in the game repository. I separated the data files to a dedicated package following the example of 0ad[1] and wesnoth[2] which are using the same approach. Should there be a single package instead? I am using rpmlint 2.2.0. It does not raise any warning about the .desktop file version. I used 1.5 because this is the current value for this attribute as documented in the Freedesktop documentaton[3]. [1] https://src.fedoraproject.org/rpms/0ad-data/blob/rawhide/f/0ad-data.spec#_3 [2] https://src.fedoraproject.org/rpms/wesnoth/blob/rawhide/f/wesnoth.spec#_73 [3] https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2074401 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
