https://bugzilla.redhat.com/show_bug.cgi?id=2074401 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steve.traylen@xxxxxxx --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> --- Easy one - Tue Mar 3 2022 is a non existing date. You remove the font files in install section . Is it possible to remove them in the prep section to ensure they are not being used - it may not be possible. There looks to be two versioned sources in here: %global forgeurl0 https://github.com/FluffyStuff/Engine %global commit0 e495846970a1b38d00c81a3f74568030f976ed31 %global forgeurl1 https://github.com/FluffyStuff/OpenRiichi %global version1 %{version} why not two packages ? That version of the Engine is going to be lost as things stand. While openriichi-data package can be installed without openriichi the openriichi package requires the -data package. Is the data package ever useful on its own ? Is there any point having a sub package ? # rpmlint ./openriichi-0.2.1.1-1.fc37.x86_64.rpm openriichi.x86_64: E: invalid-desktopfile /usr/share/applications/openriichi.desktop value "1.5" for key "Version" in group "Desktop Entry" is not a known version can this be addressed ? The desktop file I believe needs some commands called on it , see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files (though I now realise I have this missing from one of my packages) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2074401 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
