https://bugzilla.redhat.com/show_bug.cgi?id=2057302 --- Comment #12 from Kevin Fenzi <kevin@xxxxxxxxx> --- ok, circling back around. The doc issue is a nice confusing one. ;) Basically the %doc macro takes the listed files/dirs from the buildroot and also _installs them_ in /usr/share/doc/name/ in the installroot. The make install step also appears to install docs there, so rpmbuild sees them listed twice. The best way forward IMHO is to delete them at the end of install and let the %doc macro install them for you. So: --- proxmark3.spec.1 2022-04-04 17:21:21.000000000 -0700 +++ proxmark3.spec 2022-04-16 12:03:29.704848924 -0700 @@ -19,8 +19,8 @@ %autosetup %build -make %{?_smp_mflags} clean -make %{?_smp_mflags} SKIPLUASYSTEM=1 +make %{?_smp_mflags} V=1 clean +make %{?_smp_mflags} V=1 SKIPLUASYSTEM=1 rm -rf %{buildroot}/doc/datasheets/ rm -rf %{buildroot}/doc/original_proxmark3/ @@ -29,9 +29,10 @@ chmod -x ./client/cmdscripts/rdv4_init_extflash.cmd chmod -x ./client/pyscripts/xorcheck.py chmod -x ./client/cmdscripts/example.cmd -make %{?_smp_mflags} install PREFIX=%{buildroot}/usr UDEV_PREFIX=%{buildroot}/etc/udev/rules.d/ +make %{?_smp_mflags} V=1 install PREFIX=%{buildroot}/usr UDEV_PREFIX=%{buildroot}/etc/udev/rules.d/ chmod -x %{buildroot}/usr/share/proxmark3/firmware/fullimage.elf chmod -x %{buildroot}/usr/share/proxmark3/firmware/bootrom.elf +rm -rf %{buildroot}%{_datadir}/doc/proxmark3 %files %{_sysconfdir}/udev/rules.d/77-pm3-usb-device-blacklist.rules @@ -41,7 +42,6 @@ %{_bindir}/pm3-flash-bootrom %{_bindir}/pm3-flash-fullimage %{_bindir}/proxmark3 -%{_docdir}/proxmark3 %{_datadir}/proxmark3 %license LICENSE.txt I also think it would be good to pass V=1 to make here to get the full compile logs. Anyhow, can you take a look at that and confirm it makes sense? Then, I don't see any more blockers here, so I can go ahead and sponsor you and we can get the package in. ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2057302 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
