https://bugzilla.redhat.com/show_bug.cgi?id=2057302 --- Comment #11 from Kevin Fenzi <kevin@xxxxxxxxx> --- (In reply to marlin.soose from comment #10) > I'd like to understand more about why turning off debug is not recommended, > but a regex to hit every single file except "fullimage/bootrom.elf" is okay. > Why is "%global debug_package %{nil}" available if it shouldn't be used? Or, > rather, when is it appropriate to use this included option? Well, the guidelines aren't 100% clear here... I guess having usable debuginfo is a "SHOULD" not a "MUST". It annoys me because I can see someone hitting a crash and trying to debug it and getting stuck. I know thats unlikely. > > I have moved removing the executable bit down in the %install chain and this > seems to work but I don't quite understand why, since these files should > already be built by %build, nor why I can't use a macro for the first few > operations here: Well, until you run the 'make install' there's nothing installed. ;) So, if you move those to after make install you should be able to change them in the installed buildroot > > %install > chmod -x ./client/luascripts/examples/example_cmdline.lua > chmod -x ./client/cmdscripts/rdv4_init_extflash.cmd > chmod -x ./client/pyscripts/xorcheck.py > chmod -x ./client/cmdscripts/example.cmd > make %{?_smp_mflags} install PREFIX=%{buildroot}/usr > UDEV_PREFIX=%{buildroot}/etc/udev/rules.d/ > chmod -x %{buildroot}/usr/share/proxmark3/firmware/fullimage.elf > chmod -x %{buildroot}/usr/share/proxmark3/firmware/bootrom.elf > but fails with: > > File listed twice: /usr/share/doc/proxmark3 Are any of the above docs? Docs are copied in install too... > Empty %files file > /builddir/build/BUILD/proxmark3-4.14831/debugsourcefiles.list So, it can't find the sources (.c/.h/etc). > Full spec: > https://download.copr.fedorainfracloud.org/results/s00se/proxmark3/fedora-35- > x86_64/03954951-proxmark3/proxmark3.spec Thanks, I really hope to have time to look this weekend... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2057302 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
