https://bugzilla.redhat.com/show_bug.cgi?id=2074652 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Licensing: Most of the code is under MIT license (no headers in files though), but src/sphinx_theme_builder/_internal/passthrough.py is under BSD 3-Clause License, so please mention this in a comment next to the License: field and update it. Source matches upstream: $ sha512sum sphinx-theme-builder-0.2.0a14.tar.gz sphinx-theme-builder-0.2.0a14.tar.gz.orig 15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9 sphinx-theme-builder-0.2.0a14.tar.gz 15217073a98367f28c5578901f503bc1820ed6b7338f7be773768f6e847c11980f9be6ad9fa8a6adca6edb2ae44ae0f592e05cbc796f2e909efa9bfe979aa5a9 sphinx-theme-builder-0.2.0a14.tar.gz.orig Builds fine in mock. Internal testsuite passes. Spec is clean and legible. rpmlint clean. Requires and provides are sane: $ rpm -qpR python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm ; echo ; rpm -qp --provides python3-sphinx-theme-builder-0.2.0-0.1.a14.fc37.noarch.rpm /usr/bin/python3 python(abi) = 3.10 python3.10dist(nodeenv) python3.10dist(packaging) python3.10dist(pep621) python3.10dist(rich) python3.10dist(setuptools) python3.10dist(tomli) python-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3.10-sphinx-theme-builder = 0.2.0-0.1.a14.fc37 python3.10dist(sphinx-theme-builder) = 0.2~a14 python3dist(sphinx-theme-builder) = 0.2~a14 You can fix the minor licensing issue when importing, package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2074652 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
