https://bugzilla.redhat.com/show_bug.cgi?id=2074651 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Licensing is fine (MIT). Source matches upstream: $ sha512sum sphinx-autobuild-2021.3.14.tar.gz sphinx-autobuild-2021.3.14.tar.gz.orig 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz 8e3bcd2466343b95baa991ff8d7da9bca8978f54c4c0720390724e5ada32c5dfa25b9ad2564d675ce5489c7627bc437bde7d98b8efb6bdfe4ea5ace152e147a7 sphinx-autobuild-2021.3.14.tar.gz.orig Builds fine in mock. Internal testsuite passes. Spec is clean and legible. rpmlint clean. Requires and provides are sane: $ rpm -qpR python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm /usr/bin/python3 python(abi) = 3.10 python3.10dist(colorama) python3.10dist(livereload) python3.10dist(sphinx) $ rpm -qp --provides python3-sphinx-autobuild-2021.3.14-1.fc37.noarch.rpm python-sphinx-autobuild = 2021.3.14-1.fc37 python3-sphinx-autobuild = 2021.3.14-1.fc37 python3.10-sphinx-autobuild = 2021.3.14-1.fc37 python3.10dist(sphinx-autobuild) = 2021.3.14 python3dist(sphinx-autobuild) = 2021.3.14 jquery 3.5.1 and underscore 1.13.1 are bundled in the doc subpackage, you might want to declare that in Provides: bundled(). This is of course coming from sphinx and was discussed as recently as February: https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/message/ZVILBEZB6MIZXP3JVQSVNCP7Q6MK4G7D/ . You can fix this while importing as the package is good otherwise. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2074651 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
