https://bugzilla.redhat.com/show_bug.cgi?id=2072752 --- Comment #2 from Diego Herrera <dherrera@xxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/dherrera/tinyexr/fedora-36-x86_64/04181151-tinyexr/tinyexr-1.0.1-5.fc36.src.rpm SRPM URL: https://download.copr.fedorainfracloud.org/results/dherrera/tinyexr/fedora-36-x86_64/04181151-tinyexr/tinyexr.spec (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > Release: 1%{?dist} > > %changelog > > ... > > Suggestion: https://docs.pagure.org/fedora-infra.rpmautospec/index.html Took your sugestion, I was planning to learn about it, found out this was the perfect ocasion, thx for the push. > > > mkdir -p ${RPM_BUILD_ROOT}%{_datadir}/licenses/%{name}/ > > install -p -m 644 %{SOURCE1} \ > > ${RPM_BUILD_ROOT}%{_datadir}/licenses/%{name}/LICENSE > > I don't think you need to do this. Just '%license %{SOURCE1}' should be > enough. > Cleaned up this part. > fedora-review says: > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_devel_packages > > The %files pattern seems wrong: %{_libdir}/libtinyexr.so should be in -devel. > Fixed! > Hmm, if I go to https://www.openexr.com/, they link to > https://github.com/AcademySoftwareFoundation/openexr, > which has version 3.1.4 as the latest. https://github.com/syoyo/tinyexr > seems to be a dead project. I mailed the maintainer and he is still active, also I think it's a good idea to package it since the Godot project already uses it (this library is actually packaged there as an internal library). My main interest though is to get it so I can update the Opentoonz package, since this is a dependency for the current stable version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2072752 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
