https://bugzilla.redhat.com/show_bug.cgi?id=2061730 --- Comment #7 from Tomáš Bžatek <tbzatek@xxxxxxxxxx> --- (In reply to Vojtech Trefny from comment #1) > Just few notes for now: > > - issue from fedora-review: "File listed twice: /usr/share/doc/nvme-stas", > I'm not sure why but probably the combination of "%doc README.md" and "%doc > %{_pkgdocdir}" Looks like a noise, my attempt to use only single %doc ends up with RPM build errors: Can't mix special %doc with other forms: /usr/share/doc/nvme-stas > - "staslib/glibudev.py" is licensed under LGPL but if I understand it > correctly the result still could be under ASL 2.0 so the "Licence:" field in > spec should be correct Yeah, I think it's the Lesser difference. > - if "staslib" is meant to be a public Python API it should be packaged in a > separate package, if it is just an internal library for the binary, it > should be OK to have it in the nvme-stas package See comment 6, otherwise I would keep it internal. Updated build, spec file synced with upstream: Spec URL: https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-rawhide-x86_64/04083703-nvme-stas/nvme-stas.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-rawhide-x86_64/04083703-nvme-stas/nvme-stas-1.0~rc7-1.fc37.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2061730 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
