https://bugzilla.redhat.com/show_bug.cgi?id=2057302 --- Comment #6 from Kevin Fenzi <kevin@xxxxxxxxx> --- (In reply to marlin.soose from comment #5) > > Could you perhaps chmod -x them? Or do they need to be executable? > > Thanks for the tip, I added the entries as such under %install > > chmod -x %{buildroot}/usr/share/proxmark3/firmware/fullimage.elf > > but brp-strip still tries to strip them and fails to detect their format. > I'm not sure if this is because they are already getting stripped in the > cross compilation process? If so, skipping the strip seems more "stay > upstream" but if a patch is preferred, please advise. Would it be worth making a -firmware subpackage and making it noarch? Assuming the firmware is arch independent and builds the same on different arches? > > Can you enable most of the tests, and just disable those? > > The tests are grouped in such a way that I thought it would be preferred to > stay close to upstream again and just not use the optional checks. > > I use and work with the moving master branch, there are out of band checks > before releases are tagged, which include confirming functionality. I'm > hoping, as a package maintainer for Fedora, to upkeep and ensure that all > releases matching the upstream releases remain functional. Sure, it's optional. If it's easy to run some sanity tests at build time I think it's useful, but if not, the upstream tests at release time are better than no tests at all for sure. ;) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2057302 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
