Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qemu-launcher - A graphical front-end to Qemu virtual machines https://bugzilla.redhat.com/show_bug.cgi?id=400521 ------- Additional Comments From nsboyle@xxxxxxxxx 2007-12-04 22:56 EST ------- (In reply to comment #4) > need one more update here > 1)directory is not owned by package? > /usr/share/qemu-launcher I was globbing the files in /usr/share/qemu-launcher, instead of just specifying the directory. Fixed. > 2) any specific need to have %clean as > rm -rf %{buildroot}/%{prefix} and not simple rm -rf %{buildroot} No good reason I know of. Fixed. > 3) good to keep timestamps of files from upstream tarball I grabbed a timestamp preserved copy from upstream, and am now patching the Makefile to preserve timestamps on install. Updated files: http://nboyle.fedorapeople.org/qemu-launcher.spec http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review