https://bugzilla.redhat.com/show_bug.cgi?id=2041073 --- Comment #15 from Tomáš Bžatek <tbzatek@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #14) > > [!]: Each %files section contains %defattr if rpm < 4.4 > > Note: %defattr present but not needed > > Drop %defattr lines, they're not doing anything rpm isn't already doing. Removed. There's a lot of ancient stuff still living in many other spec files around... > > [-]: A package which is used by another package via an egg interface should > > provide egg info. > > [-]: Package meets the Packaging Guidelines::Python > > Ideally, this should provide some kind of Python metadata so that Python > programs can register it as a dependency. You can see how this is done in > createrepo_c as an example: > https://github.com/rpm-software-management/createrepo_c/commit/ > 22f25729801a3d62f903d92b40b147f1222295dc This is changing in upstream right now: https://github.com/linux-nvme/libnvme/pull/257 Though my experiments so far indicate it's rather broken, the meson module requiring a git repo, not working on a release tarball, etc. Still work in progress and as I didn't want to block this review, let's just deal with this separately once ready upstream. Rebased for the upstream -rc4 release, changes to the spec file are fairly minimal: https://copr.fedorainfracloud.org/coprs/g/storage/udisks-daily/build/3590389/ Spec: https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-36-x86_64/03590389-libnvme/libnvme.spec SRPM: https://download.copr.fedorainfracloud.org/results/@storage/udisks-daily/fedora-36-x86_64/03590389-libnvme/libnvme-1.0~rc4-1.fc36.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2041073 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
