[Bug 2041073] Review Request: libnvme - Linux-native nvme device management library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2041073



--- Comment #14 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> [!]: Each %files section contains %defattr if rpm < 4.4
>      Note: %defattr present but not needed

Drop %defattr lines, they're not doing anything rpm isn't already doing.

> [-]: A package which is used by another package via an egg interface should
>      provide egg info.
> [-]: Package meets the Packaging Guidelines::Python

Ideally, this should provide some kind of Python metadata so that Python
programs can register it as a dependency. You can see how this is done in
createrepo_c as an example:
https://github.com/rpm-software-management/createrepo_c/commit/22f25729801a3d62f903d92b40b147f1222295dc


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2041073
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux