https://bugzilla.redhat.com/show_bug.cgi?id=2040118 --- Comment #21 from Garry T. Williams <gtwilliams@xxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/gtwilliams/deal/v3.1.11/deal.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gtwilliams/deal/fedora-35-x86_64/03577445-deal/deal-3.1.11-6.fc35.src.rpm > Looks good, though there's one bit that I'm still thinking about. > The packaging guidelines say: > > Files located in %_pkgdocdir must not affect the runtime of the > > packaged software. The software must function properly and with > > unchanged functionality if those files are modified, removed or > > not installed at all. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation It's good that you were worried about this. Actually the contents of docs/html/ex and ex are not completely duplicated. So I should have just de-duped based on the original author's files in both directories. My code is wrong to begin with. :-( So following the guidelines, I am now just copying both directories in %install and then de-duping, with a symlink, any files that are duplicated, making %{_datadir}/ex the actual files and installing symlinks over any duplicated files in %{_docdir}/html/ex. After this change, both directories contain exactly what the original author intended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
