https://bugzilla.redhat.com/show_bug.cgi?id=2040118 --- Comment #20 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- Looks good, though there's one bit that I'm still thinking about. The packaging guidelines say: > Files located in %_pkgdocdir must not affect the runtime of the packaged software. > The software must function properly and with unchanged functionality if those files are modified, removed or not installed at all. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation The files in %{_datadir}/%{name}/ex/ are symlinks to files in %{_pkgdocdir}/html/ex/, which violates this rule - if the files in %{_pkgdocdir} are deleted, the symlinks will become broken (dangling). I suppose we could comply with the guidelines by flipping the files, i.e. making those in %{_pkgdocdir} symlinks to those in %{_datadir}/%{name}: > for f in %{build_docs}/html/ex/*.txt; do \ > ( \ > DESTINATION="%{buildroot}%{_datadir}/ex/$(basename "${f}" .txt).tcl"; \ > mv "$f" "$DESTINATION"; \ > ln -sr "$DESTINATION" "$f"; \ > ) \ > done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
