https://bugzilla.redhat.com/show_bug.cgi?id=2034758 --- Comment #29 from Dave Dykstra <dwd@xxxxxxxxxxxxxxxxx> --- (In reply to Maxwell G from comment #28) > > %undefine _debugsource_packages > > Is this still necessary? Yes. Without it, the error shown in the comment appears. Here's a scratch build with that: https://kojipkgs.fedoraproject.org//work/tasks/9892/83179892/build.log > > %{_sysconfdir}/bash_completion.d/* > > Bash completions should be installed in > `%{_datadir}/bash-completion/completions`. Oh, I hadn't heard about that other directory. Ok I'll update that after hearing from Mattia if there's anything else. > > %posttrans > > # clean out empty directories under /etc/singularity > > rmdir %{_sysconfdir}/singularity/* %{_sysconfdir}/singularity 2>/dev/null || true > > This looks strange to me. What is it actually needed for? It's because the previous package didn't clean up everything properly on deletion. This cleanup is needed so apptainer can figure out whether or not the system administrator has fully converted the configuration file to the new name: it warns if /etc/singularity still exists (more precisely, if "$(basename %{_sysconfdir})/singularity" still exists). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2034758 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
