https://bugzilla.redhat.com/show_bug.cgi?id=2034758 --- Comment #28 from Maxwell G <gotmax@e.email> --- Thank you for all your work on this! I have a couple more minor comments. > %undefine _debugsource_packages Is this still necessary? > %{_sysconfdir}/bash_completion.d/* Bash completions should be installed in `%{_datadir}/bash-completion/completions`. > %posttrans > # clean out empty directories under /etc/singularity > rmdir %{_sysconfdir}/singularity/* %{_sysconfdir}/singularity 2>/dev/null || true This looks strange to me. What is it actually needed for? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2034758 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
