https://bugzilla.redhat.com/show_bug.cgi?id=2054599 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > %{?!python3_pkgversion:%global python3_pkgversion 3} I know of no distribution that has %pyproject_* macros but does not define %python3_pkgversion. Why do you think this is needed in the spec file? I believe it should be removed, but maybe I don't have all the information. > %global srcname specfile (personal opinion) There is no good reason to define this macro. Consider not doing it. See https://lists.fedoraproject.org/archives/list/python-devel@xxxxxxxxxxxxxxxxxxxxxxx/message/BEW5NUG2T5OWSIRB7KGCVJRBCSBJZE37/ search for "As does Zbyszek," > %{?python_provide:%python_provide python3-%{srcname}} This macro is deprecated and does nothing useful. It should be removed. > %license LICENSE The license file is already included in %{pyproject_files}. It should be removed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2054599 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
