[Bug 2034758] Review Request: apptainer - new name for singularity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2034758



--- Comment #17 from Mattia Verga <mattia.verga@xxxxxxxxxxxxxx> ---
Can you please backport the patch into the provided files, so that I can run
fedora-review? Otherwise it will fail and doesn't produce any useful output.

I think you have fixed all my points reported before, just some minor
tweaks/cleanup:
- macros in comments should have '%%' not just '%'
- not sure if it's needed for Suse build, but ExclusiveOS is not something I
have ever seen in Fedora
- same for ExcludeArch ppc64, Fedora doesn't build for ppc64 anymore, so it
should be no more needed
- empty changelog?

Everything else looks fine.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2034758
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux