https://bugzilla.redhat.com/show_bug.cgi?id=2045955 --- Comment #7 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- (In reply to Felix Schwarz from comment #6) > SRPM URL: > https://mystro256.fedorapeople.org/rocm-compilersupport-5.0.0-1.fc36.src.rpm > > rocm-comgr contains LICENSE.txt, NOTICES.txt, and README.md in > /usr/share/amd_comgr (duplicated, should be removed) Ok done, thanks! I should tell upstream this is a poor location to install them: share/doc/amd_comgr would be better. > > Some patches could use a link or an explanation: > > - "Upstream is ok with the patch, but my patch isn't currently > upstreamable": why is the patch ok for Fedora but not for upstream? Sure, I realize my comment was very confusing, see updated. The issue is that upstream still wants to compile statically, but my patch forces dynamic linking. I need to figure out how to fix my patch to autodetect before submitting upstream. > - "Fix location of cmake file, I've already emailed upstream a patch" - link? I emailed the patch directly to the developers, not a public mailing list. Alternatively, I can make a pull request on github if desired. As far a I know, github is just a mirror of an internal repo they have, so I thought it would be easier for them to apply the patch if I email the developers directly. > > One surprising thing was the number of required compilers: > > BuildRequires: gcc > BuildRequires: gcc-c++ > BuildRequires: clang-devel > > the package needs gcc AND clang? My bad, I always add gcc out of habit :) Spec URL: https://mystro256.fedorapeople.org/rocm-compilersupport.spec SRPM URL: https://mystro256.fedorapeople.org/rocm-device-libs-5.0.0-1.fc36.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/mystro256/rocm-opencl/build/3460575/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2045955 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
