https://bugzilla.redhat.com/show_bug.cgi?id=2051874 --- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Jan Macku from comment #7) > So, you are suggesting to drop logic that handles kernel-cmdline ifname= ? > > So ifcfg-devname would only handle only ifcfg DEVICE= ? That's my guess, but I'm not an expert on any of this. I'll ask Yu to take a look. (In reply to Fabio Valentini from comment #8) > Note that since this package has a subpackage that ships a binary, you'll > need to specify the license for that subpackage separately. > Inheriting "License: GPLv3" from the source package is certainly not > correct, since lots of the crate's dependencies are "ASL 2.0 or MIT" or > "MIT" only. Are you sure? MIT + GPLv3 is effectively GPLv3, and License specifies the effective license [https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_field]. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051874 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure