https://bugzilla.redhat.com/show_bug.cgi?id=2050275 Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > Source0: https://github.com/opentoonz/opentoonz/archive/refs/tags/v1.5.0.tar.gz You can use %{version} as part of the Source URL so you don't have to edit it every time. > BuildRequires: cmake gcc gcc-c++ qt5-qtbase-devel qt5-qtsvg-devel > BuildRequires: qt5-qtscript-devel qt5-qttools-devel qt5-qtmultimedia-devel > BuildRequires: qt5-qtserialport-devel opencv-devel libtiff-devel libpng-devel > ... This is allowed, but personally I'd really encourage you to sort these alphabetically and possibly separate them one-per-line. > %package data > Summary: OpenToonz data files > BuildArch: noarch > ... > %package doc > Summary: OpenToonz doc files Shouldn't the documentation be noarch as well? > cd redhat-linux-build > %make_build Does "%cmake_build" not work properly here? > cd redhat-linux-build > %make_install What about "%cmake_install" here? > desktop-file-install \ > --dir ${RPM_BUILD_ROOT}%{_datadir}/applications \ > --delete-original \ > ${RPM_BUILD_ROOT}%{_datadir}/applications/io.github.OpenToonz.desktop If I'm reading this right, this replaces the file with itself. Instead of installing the file over itself, you can just run "desktop-file-validate" on it. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2050275 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
